Skip to content

fix: remove default replicas value to support HPA scaling#1284

Merged
rm3l merged 7 commits intoredhat-developer:mainfrom
Fortune-Ndlovu:remove-default-replicas-for-hpa
Jun 20, 2025
Merged

fix: remove default replicas value to support HPA scaling#1284
rm3l merged 7 commits intoredhat-developer:mainfrom
Fortune-Ndlovu:remove-default-replicas-for-hpa

Conversation

@Fortune-Ndlovu
Copy link
Copy Markdown
Member

Description

This PR emoves the replicas: 1 field from config/profile/rhdh/default-config/deployment.yaml.

This change allows users to apply Horizontal Pod Autoscalers (HPA) to the Backstage deployment without the operator reverting replica counts.

  • Verified locally on Kind with metrics-server
  • Confirmed HPA scales to 3 under CPU load
  • Operator no longer resets to 1

You can view my entire replication of the issue and overall steps I took to ensure the fix works, in the issue comments section: https://issues.redhat.com/browse/RHIDP-7857

Which issue(s) does this PR fix or relate to

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

Co-authored-by: Fortune-Ndlovu <Fortune-Ndlovu@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Files changed in bundle and installer generation!

Those changes to the operator bundle/installer manifests should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

Comment thread config/profile/rhdh/default-config/deployment.yaml
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Co-authored-by: Fortune-Ndlovu <Fortune-Ndlovu@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Files changed in bundle and installer generation!

Those changes to the operator bundle/installer manifests should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

Comment thread config/profile/rhdh/default-config/db-statefulset.yaml
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Co-authored-by: Fortune-Ndlovu <Fortune-Ndlovu@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Files changed in bundle and installer generation!

Those changes to the operator bundle/installer manifests should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

@rm3l rm3l closed this Jun 19, 2025
@rm3l rm3l reopened this Jun 19, 2025
Copy link
Copy Markdown
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jun 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gazarenkov, rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rm3l rm3l merged commit c88bc03 into redhat-developer:main Jun 20, 2025
7 checks passed
Fortune-Ndlovu added a commit to Fortune-Ndlovu/rhdh-operator that referenced this pull request Sep 6, 2025
…eloper#1284)

* fix: remove default replicas value to support HPA scaling

* Regenerate bundle/installer manifests

Co-authored-by: Fortune-Ndlovu <Fortune-Ndlovu@users.noreply.github.com>

* Commented out  in Deployment and StatefulSet templates.

Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>

* Commented out  in Deployment and StatefulSet templates.

Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>

* Regenerate bundle/installer manifests

Co-authored-by: Fortune-Ndlovu <Fortune-Ndlovu@users.noreply.github.com>

* fixup

Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>

* Regenerate bundle/installer manifests

Co-authored-by: Fortune-Ndlovu <Fortune-Ndlovu@users.noreply.github.com>

---------

Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Fortune-Ndlovu <Fortune-Ndlovu@users.noreply.github.com>
Co-authored-by: Armel Soro <asoro@redhat.com> 
Co-authored-by: Gennady Azarenkov <gazarenkov@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants