doc: add backend_secret config to orchestrator#1567
Conversation
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Verify that the
extraEnvs.secretsblock in the Backstage CR matches the actual CRD schema (env, envFrom or secrets) and adjust the example if needed to avoid misconfiguration. - Include a reference or snippet showing how to create the Kubernetes Secret containing the BACKEND_SECRET key to guide users through the setup.
- Add a note to clarify what permissions or scopes the
subject: orchestratortoken grants to help users understand its impact on downstream plugins.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Verify that the `extraEnvs.secrets` block in the Backstage CR matches the actual CRD schema (env, envFrom or secrets) and adjust the example if needed to avoid misconfiguration.
- Include a reference or snippet showing how to create the Kubernetes Secret containing the BACKEND_SECRET key to guide users through the setup.
- Add a note to clarify what permissions or scopes the `subject: orchestrator` token grants to help users understand its impact on downstream plugins.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Cherry-picking to 1.7, based on the priority and fix version of https://issues.redhat.com/browse/FLPATH-2627 /cherry-pick release-1.7 |
|
@rm3l: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
20cde8d
into
redhat-developer:main
|
@rm3l: #1567 failed to apply on top of branch "release-1.7": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* Update app config in orchestrator example * update doc * add secret example
Description
To enable notification for Orchestrator, this PR adds the backend secret token under the auth config in the orchestrator example. So the user is aware that the secret needs to be configured for Orchestrator.
Which issue(s) does this PR fix or relate to
PR acceptance criteria
Summary by Sourcery
Enable Orchestrator notifications by adding backend secret configuration to the orchestrator example and updating the documentation to guide users on configuring the BACKEND_SECRET.
Enhancements:
Documentation: