Skip to content

fix(orchestrator): simplify workflows tab layout #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lokanandaprabhu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(orchestrator): simplify workflows tab layout #2772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions workspaces/orchestrator/.changeset/workflows-tab-simplify-layout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@red-hat-developer-hub/backstage-plugin-orchestrator': patch
---

Simplify workflows tab layout by rendering `WorkflowsTable` directly inside `Content` instead of an extra MUI `Grid` wrapper.
10 changes: 1 addition & 9 deletions ...orchestrator/plugins/orchestrator/src/components/OrchestratorPage/WorkflowsTabContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ import {
} from '@backstage/core-components';
import { useApi } from '@backstage/core-plugin-api';

import Grid from '@mui/material/Grid';

import { WorkflowOverviewDTO } from '@red-hat-developer-hub/backstage-plugin-orchestrator-common';

import { orchestratorApiRef } from '../../api';
Expand Down Expand Up @@ -65,13 +63,7 @@ export const WorkflowsTabContent = ({
<Content noPadding>
{loading ? <Progress /> : null}
{error ? <ResponseErrorPanel error={error} /> : null}
{isReady ? (
<Grid container direction="column">
<Grid item xs={12}>
<WorkflowsTable items={value ?? []} />
</Grid>
</Grid>
) : null}
{isReady ? <WorkflowsTable items={value ?? []} /> : null}
</Content>
);
};
Loading
⚡