fix(lightspeed): added empty state for unconfigured LLM#2781
fix(lightspeed): added empty state for unconfigured LLM#2781ciiay wants to merge 7 commits intoredhat-developer:mainfrom
Conversation
Signed-off-by: Yi Cai <yicai@redhat.com>
Code Review by Qodo
1.
|
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Review Summary by QodoAdd empty and error states for Lightspeed LLM configuration
WalkthroughsDescription• Added empty state UI for unconfigured LLM models • Added error state UI for failed model loading • Added loading state UI while fetching models • Extended translations across 6 languages • Added comprehensive test coverage for new states Diagramflowchart LR
A["Models API"] -->|loading| B["Loading State"]
A -->|error| C["Error State with Retry"]
A -->|empty list| D["Not Configured State"]
A -->|success| E["Chat Interface"]
File Changes1. workspaces/lightspeed/plugins/lightspeed/src/components/LightspeedChatModelsState.tsx
|
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
|
Hi @ShiranHi , any input to the empty state display? |
|
Hi,
I’m no longer working with Red Hat. Please remove me from your list and
find @shiran for any UX questions.
Thank you
April Ma
Sr. Interaction Designer, User Experience Design
Red Hat <https://www.redhat.com/>
<https://www.redhat.com/>
…On Thu, Apr 16, 2026 at 02:43 Yi C ***@***.***> wrote:
*ciiay* left a comment (redhat-developer/rhdh-plugins#2781)
<#2781 (comment)>
Hi @aprilma419 <https://github.com/aprilma419> , any input to the empty
state display?
—
Reply to this email directly, view it on GitHub
<#2781 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKS7NJ3HMAFE6RWU6CEMQML4V7J6HAVCNFSM6AAAAACX2SBGWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DENJUGU3TENBRGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@ciiay looks good to me, I have some small comments:
|
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
|
Hi @ShiranHi , thanks for the input. I have updated the screenshot in the PR description. Can you take a look and see if it looks good now? |
Signed-off-by: Yi Cai <yicai@redhat.com>
Thank you! Looks good to me! |
| const modeToUse = | ||
| rawMode === ChatbotDisplayMode.embedded | ||
| ? ChatbotDisplayMode.default | ||
| : rawMode; |
There was a problem hiding this comment.
This makes the persisting & retaining user mode selection feature only work on overlay and docked mode? I am trying to understand why we need to skip the full-screen mode here, most of the users may use full screen mode, with this change to get to fullscreen then user have to change it manually everytime via mode selector now?
Jdubrick
left a comment
There was a problem hiding this comment.
Thanks for this! Couple of things I have in mind / questions:
- In the blurb about using Lightspeed and connecting to an LLM to get started, I think we should maybe be also mentioning that they should be contacting an administrator to get it setup? A normal user of Lightspeed won't have the access required to set up the secrets required
- I like the link to Llama Stack, but I think if we leave a link there it should be to our rhdh documentation instead of the llama stack github
- I noticed in the test steps it instructs to set the inference settings to an empty array
[], what version of Lightspeed Core / Llama Stack did you test this against? My concern is that it will never truly be empty as we always will have our RAG transformer in the inference, even if there is no LLM:
I.e.
- provider_id: sentence-transformers
provider_type: inline::sentence-transformers
config: {}
The content in main of https://github.com/redhat-ai-dev/lightspeed-configs/tree/main can spin up a local LCORE instance with our latest config set
|
Hi @Jdubrick , thanks for the review and feedback.
Good catch 👍 You’re right about the inference config. I tested against latest I agree with the other two points. I’ll get input from our UX team and update the wording and links accordingly. |
|
Hi @ShiranHi , any suggestions to these points? Shall we use Installing and configuring Red Hat Developer Lightspeed for Red Hat Developer Hub for the second point?
|
Signed-off-by: Yi Cai <yicai@redhat.com>
|



Hey, I just made a Pull Request!
For RHIDP-12816
✔️ Checklist
Test steps:
run.yamlcomment out your provider config in the inference array, for example:storage.backendin yourrun.yaml)Screenshot(updated on 4/16):