Quick fix not being applied

[TrevCraw]

VS Code version: 1.84.1
Tools for MicroProfile version: v0.10.0 and v0.11.2023102104
OS: Windows 11

When attempting to apply a quick fix to add @Liveness or @Readiness annotations, no action occurs. Refer to video below.

Recording.2023-11-07.125246.mp4

[scottkurz]

I also noticed the "Generate OpenAPI Annotations ..." code action doesn't seem to get applied either. I mention in case it's a different path because it's of code action kind = "source", (so you apply via right-click, "Source Action...", and then select in the child menu). I'm also on v0.10.0.

[angelozerr]

Indeed it doesnt work.

The resolve code action uses a command to send some telemtry.

Here the trace:

[Trace - 7:35:03 PM] Sending request 'codeAction/resolve - (17)'.
Params: {
    "title": "Insert @Liveness",
    "kind": "quickfix",
    "diagnostics": [
        {
            "range": {
                "start": {
                    "line": 5,
                    "character": 13
                },
                "end": {
                    "line": 5,
                    "character": 28
                }
            },
            "message": "The class org.acme.MyLivenessCheck implementing the HealthCheck interface should use the @Liveness or @Readiness annotation.",
            "code": "HealthAnnotationMissing",
            "severity": 1,
            "source": "microprofile-health"
        }
    ],
    "command": {
        "title": "Insert @Liveness",
        "command": "microprofile.applyCodeAction",
        "arguments": [
            {
                "title": "Insert @Liveness",
                "kind": {
                    "value": "quickfix"
                },
                "data": {
                    "participantId": "org.eclipse.lsp4mp.jdt.internal.health.java.HealthAnnotationMissingQuickFix",
                    "documentUri": "file:///c%3A/Users/azerr/git/intellij-quarkus/projects/lsp4mp/projects/maven/microprofile-health-3/src/main/java/org/acme/MyLivenessCheck.java",
                    "range": {
                        "start": {
                            "line": 5,
                            "character": 13
                        },
                        "end": {
                            "line": 5,
                            "character": 28
                        }
                    },
                    "extendedData": {
                        "annotation": [
                            "org.eclipse.microprofile.health.Liveness"
                        ]
                    },
                    "resourceOperationSupported": true,
                    "commandConfigurationUpdateSupported": true,
                    "id": "InsertMissingHealthAnnotation"
                },
                "diagnostics": [
                    {
                        "severity": "Error",
                        "message": "The class org.acme.MyLivenessCheck implementing the HealthCheck interface should use the @Liveness or @Readiness annotation.",
                        "range": [
                            {
                                "line": 5,
                                "character": 13
                            },
                            {
                                "line": 5,
                                "character": 28
                            }
                        ],
                        "source": "microprofile-health",
                        "code": "HealthAnnotationMissing"
                    }
                ]
            },
            {
                "a": false,
                "b": {
                    "w": 0,
                    "u": {
                        "i": -1,
                        "end": 0
                    }
                }
            }
        ]
    }
}

@datho7561 have you some idea why it fails? Do you know what is the data

 {
                "a": false,
                "b": {
                    "w": 0,
                    "u": {
                        "i": -1,
                        "end": 0
                    }
                }

[datho7561]

I think it's supposed to be the cancellation token, which if I recall correctly I'm expecting to be a string: https://github.com/redhat-developer/vscode-microprofile/blob/master/src/extension.ts#L259.

Maybe the order or type of the parameters to this handler changed in a recent version of VS Code. It doesn't seem like we upgraded the language client. I think the cancellation token is unrelated. I debugged the extension (debug point on extension.ts#143), and it seems like the resolved code action contains neither a edit to perform nor a command to execute.

[angelozerr]

Indeed I have seen that. Im not sure but I have the impression that we loose data content in

vscode-microprofile/src/extension.ts

Line 140 in 46de0ee

let codeAction = await languageClient.code2ProtocolConverter.asCodeAction(codeActionOrCommand as VSCodeAction);

I dont remember if resolve on lsp4mp requires this data

[datho7561]

Yes, I agree. It seems like the diagnostic range is lost performing this conversion, so I'm guessing this is causing code action resolution to fail on the language server side.

[datho7561]

From debugger:

JSON.stringify(codeActionOrCommand.diagnostics[0].range)
'[{"line":9,"character":13},{"line":9,"character":26}]'
languageClient.code2ProtocolConverter.asRange(codeActionOrCommand.diagnostics[0].range)
{start: undefined, end: undefined}

I think it's a bug in VS Code? I'll double check their code.