Update contributing guide#10
Merged
angelozerr merged 1 commit intoredhat-developer:masterfrom Aug 3, 2020
Merged
Conversation
rzgry
force-pushed
the
update-contributing-guide
branch
2 times, most recently
from
61ccad5 to
04a37ed
Compare
datho7561
requested changes
Jul 29, 2020
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
The changes look pretty good, but I think there are a few places where the wording can be more clear, and there is a broken link. I also think Angelo wanted to do a read through before merging.
Signed-off-by: Ryan Zegray <ryan.zegray@ibm.com>
rzgry
force-pushed
the
update-contributing-guide
branch
from
04a37ed to
6908d8b
Compare
Contributor
|
Thanks @rzgry ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
Updates contributing.md and the images used in readme/contributing files
Also removed some now unused images. IE. macPermissions.png as vscode-microprofile does not have any ui tests.
Can preview the updated contributing.md here https://github.com/rzgry/vscode-microprofile/blob/update-contributing-guide/CONTRIBUTING.md
Signed-off-by: Ryan Zegray ryan.zegray@ibm.com