Skip to content

Don't throw an error popup when MicroProfile LS cancel the inlay hint process#123

Merged
datho7561 merged 1 commit intoredhat-developer:masterfrom
angelozerr:inlayhint-cancel
Oct 4, 2022
Merged

Don't throw an error popup when MicroProfile LS cancel the inlay hint process#123
datho7561 merged 1 commit intoredhat-developer:masterfrom
angelozerr:inlayhint-cancel

Conversation

@angelozerr
Copy link
Copy Markdown
Contributor

Don't throw an error popup when MicroProfile LS cancel the inlay hint process.

Signed-off-by: azerr azerr@redhat.com

process.

Signed-off-by: azerr azerr@redhat.com
@angelozerr angelozerr requested a review from datho7561 October 4, 2022 11:49
@datho7561 datho7561 added the bug Something isn't working label Oct 4, 2022
@datho7561 datho7561 added this to the 0.6.0 milestone Oct 4, 2022
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, I'm not able to reproduce the "inlay hint cancelled" popup on vscode-microprofile (maybe lsp4mp is doing something different than quarkus-ls for its inlay hints?), but I think it's still a good idea to merge this PR.

@datho7561 datho7561 merged commit 96cad25 into redhat-developer:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants