Skip to content

Move to vscode-languageclient 7.0.0#68

Merged
AlexXuChen merged 1 commit intoredhat-developer:masterfrom
angelozerr:languageclient-0.7.0
Aug 27, 2021
Merged

Move to vscode-languageclient 7.0.0#68
AlexXuChen merged 1 commit intoredhat-developer:masterfrom
angelozerr:languageclient-0.7.0

Conversation

@angelozerr
Copy link
Copy Markdown
Contributor

Move to vscode-languageclient 0.7.0

Signed-off-by: azerr azerr@redhat.com

@angelozerr
Copy link
Copy Markdown
Contributor Author

Please note that we should do like https://github.com/redhat-developer/vscode-xml/pull/530/files in an another PR

Signed-off-by: azerr <azerr@redhat.com>
Copy link
Copy Markdown
Contributor

@AlexXuChen AlexXuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexXuChen AlexXuChen merged commit 849651e into redhat-developer:master Aug 27, 2021
@rgrunber
Copy link
Copy Markdown
Member

Shouldn't npm install have been run after updating the package.json to ensure package-lock.json gets updated accordingly ? I still see references to the older content in there.

@angelozerr
Copy link
Copy Markdown
Contributor Author

You are right @rgrunber -( @AlexXuChen please fix it in #69

@angelozerr angelozerr added this to the 0.4.0 milestone Aug 27, 2021
@rgrunber rgrunber changed the title Move to vscode-languageclient 0.7.0 Move to vscode-languageclient 7.0.0 Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants