[MP Config 2.0] Support for config profiles

[angelozerr]

[MP Config 2.0] Support for config profiles

See eclipse-lsp4mp/lsp4mp#78

Signed-off-by: azerr azerr@redhat.com

[angelozerr]

To check this PR, create a file with profile like microprofile-config-dev.properties and open it, you should see at first that it's a MicroProfile properties:

an dyou should benefit with completion, etc MP support .

[AlexXuChen]

If I create a file, named microprofile-config-.properties, I will get the Properties language mode and not MicroProfile properties. Is that intentional, or should we not allow microprofile-config- as a properties file?

[rgrunber]

Just curious. Does the new pattern also cover the old one ? Not that I mind repeating if the purpose is to make it very clear.

[AlexXuChen]

If you remove microprofile-config.properties from the patterns, then it will no longer recognize microprofile-config.properties as a "Microprofile properties" file

[angelozerr]

microprofile-config.properties should work, no?

[AlexXuChen]

Yes, it works if you have "microprofile-config.properties" in "filenamePatterns", but I think Roland was wondering if just "microprofile-config-?*.properties" alone will support "microprofile-config.properties", which it does not.

[rgrunber]

Ok I see. So ? matches a single character, and not (0 or 1) of the previous character.

[AlexXuChen]

For package.json, I believe it matches exactly one character, but yes, it usually means the character it follows is optional. If the latter were the case, then microprofile-config-.properties should be recognized as a MicroProfile properties file, but it isn't.

[angelozerr]

If I create a file, named microprofile-config-.properties, I will get the Properties language mode and not MicroProfile properties. Is that intentional, or should we not allow microprofile-config- as a properties file?

yes it's intentional, microprofile-config-.properties is not a valid profile.

[AlexXuChen]

microprofile-config--.properties however is recognized as a valid MicroProfile properties file

[angelozerr]

It means that profile is just - . I dont know if there is some validation for profile name. I suggest that you try to start an applicationwith the profile - and see if it retrievers the proper property on the microprofile-config--.properties

The pattern that I write is just to be sure that there is a profile

[angelozerr]

Thanks for your reviews @AlexXuChen @rgrunber