Remove quarkus-properties language and collect document selectors from extensions#8
Remove quarkus-properties language and collect document selectors from extensions#8xorye merged 1 commit intoredhat-developer:masterfrom xorye:3_remove_quarkus
Conversation
|
To test this PR:
|
rzgry
left a comment
There was a problem hiding this comment.
Looking at the schema It looks like this provides a vscode extension the ability to provide a single document selector. Would their ever be a use-case where an extension would need to provide multiple document selectors?
@rzgry thanks for the review, I will make changes. Also, to be consistent with https://github.com/microsoft/vscode-languageserver-node/blob/3eddc56d9491b6f97c5e82242a3a14421d42bea1/protocol/src/common/protocol.ts#L74, I will add |
…m extensions Signed-off-by: David Kwon <dakwon@redhat.com>
|
@rzgry @datho7561 if there aren't any more changes to be made, I'd like to merge this soon. Please let me know, thanks! |
|
For some reason, the MicroProfile Tools server trace: I don't think its caused by this PR though. I'm investigating. |
|
It's not caused by this PR, this still happens in the 1.6.0 vscode-quarkus release. I made an issue about this: redhat-developer/vscode-quarkus#296 |
Fixes #3
Signed-off-by: David Kwon dakwon@redhat.com