Skip to content

Added textmate grammar support for property expressions#95

Merged
angelozerr merged 2 commits intoredhat-developer:masterfrom
JessicaJHee:issue272
Jun 14, 2022
Merged

Added textmate grammar support for property expressions#95
angelozerr merged 2 commits intoredhat-developer:masterfrom
JessicaJHee:issue272

Conversation

@JessicaJHee
Copy link
Copy Markdown
Member

image

Fixes redhat-developer/vscode-quarkus#272

Signed-off-by: Jessica He jhe@redhat.com

Comment thread language-support/properties-support/java-properties.tmLanguage.json Outdated
Comment thread language-support/properties-support/java-properties.tmLanguage.json Outdated
Comment thread language-support/properties-support/java-properties.tmLanguage.json Outdated
Comment thread language-support/properties-support/java-properties.tmLanguage.json Outdated
Comment thread language-support/properties-support/java-properties.tmLanguage.json Outdated
Comment thread language-support/properties-support/java-properties.tmLanguage.json Outdated
Comment thread language-support/properties-support/java-properties.tmLanguage.json Outdated
@angelozerr
Copy link
Copy Markdown
Contributor

At first @JessicaJHee could you move the rule for coments, property key and property value in a repository to have the root patterns like this:

"patterns": [
       {
          "include": "#comments"
        },
        {
          "include": "#property-key"
        },
        {
          "include": "#property-value"
        }
]

I think it should be more readable.

Comment thread language-support/properties-support/java-properties.tmLanguage.json Outdated
@JessicaJHee
Copy link
Copy Markdown
Member Author

image

After the changes this is what it looks like, the links / strings that are not inside ${...} are now plain with the numbers highlighted.

Comment thread language-support/properties-support/java-properties.tmLanguage.json Outdated
@JessicaJHee
Copy link
Copy Markdown
Member Author

image

The ${} is now a light yellow colour (support.constant.handlebars.java-properties)

@fbricon
Copy link
Copy Markdown
Collaborator

fbricon commented Jun 10, 2022

@JessicaJHee in your screenshot, the variables inside urls are not colored like the others

@JessicaJHee
Copy link
Copy Markdown
Member Author

@JessicaJHee in your screenshot, the variables inside urls are not colored like the others

Okay sounds good! I will make it so that it is coloured. Initially I specifically made it so that the variables inside urls are not coloured

@JessicaJHee
Copy link
Copy Markdown
Member Author

image

Signed-off-by: Jessica He <jhe@redhat.com>
Comment thread language-support/properties-support/java-properties.tmLanguage.json Outdated
Comment thread language-support/properties-support/java-properties.tmLanguage.json Outdated
@angelozerr
Copy link
Copy Markdown
Contributor

angelozerr commented Jun 10, 2022

@JessicaJHee your last screenshot looks very promising. If we could keep the same color by fixing my 2 comments it should be really nice.

@JessicaJHee
Copy link
Copy Markdown
Member Author

Appearance after change:

image

@angelozerr angelozerr merged commit b327891 into redhat-developer:master Jun 14, 2022
@angelozerr
Copy link
Copy Markdown
Contributor

Great job @JessicaJHee !

@angelozerr angelozerr added this to the 0.5.0 milestone Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TextMate grammar support for property expressions

3 participants