Added textmate grammar support for property expressions#95
Merged
angelozerr merged 2 commits intoredhat-developer:masterfrom Jun 14, 2022
Merged
Added textmate grammar support for property expressions#95angelozerr merged 2 commits intoredhat-developer:masterfrom
angelozerr merged 2 commits intoredhat-developer:masterfrom
Conversation
angelozerr
reviewed
Jun 8, 2022
angelozerr
reviewed
Jun 9, 2022
angelozerr
reviewed
Jun 9, 2022
angelozerr
reviewed
Jun 9, 2022
angelozerr
requested changes
Jun 9, 2022
angelozerr
reviewed
Jun 9, 2022
Contributor
|
At first @JessicaJHee could you move the rule for coments, property key and property value in a repository to have the root patterns like this: "patterns": [
{
"include": "#comments"
},
{
"include": "#property-key"
},
{
"include": "#property-value"
}
]I think it should be more readable. |
angelozerr
reviewed
Jun 9, 2022
Member
Author
angelozerr
reviewed
Jun 10, 2022
Member
Author
Collaborator
|
@JessicaJHee in your screenshot, the variables inside urls are not colored like the others |
Member
Author
Okay sounds good! I will make it so that it is coloured. Initially I specifically made it so that the variables inside urls are not coloured |
Member
Author
Signed-off-by: Jessica He <jhe@redhat.com>
angelozerr
reviewed
Jun 10, 2022
angelozerr
reviewed
Jun 10, 2022
Contributor
|
@JessicaJHee your last screenshot looks very promising. If we could keep the same color by fixing my 2 comments it should be really nice. |
Member
Author
Contributor
|
Great job @JessicaJHee ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fixes redhat-developer/vscode-quarkus#272
Signed-off-by: Jessica He jhe@redhat.com