Skip to content

Commit 5d2e102

Browse files
committed
Remove cycles in module dependencies
Having cycles in the modules occaisionally prevents the extension from starting. - Run GitHub Actions check for cycles in module dependencies using dpdm - Fix cli -> tools cycle - Remove cluster -> clusterViewLoader cycle - Move name validation functions out of OpenShiftItem to avoid cycles - Refactor ServerlessFunction -> ServerlessFunctionModel to avoid cycles - Remove view -> loader -> functions cycle Signed-off-by: David Thompson <davthomp@redhat.com>
1 parent c99cab0 commit 5d2e102

31 files changed

+1156
-951
lines changed
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
name: Check for cycles in modules
2+
3+
on:
4+
push:
5+
branches: [main]
6+
pull_request:
7+
branches: [main]
8+
9+
jobs:
10+
cyclesCheck:
11+
runs-on: ubuntu-latest
12+
13+
# Steps represent a sequence of tasks that will be executed as part of the job
14+
steps:
15+
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
16+
- uses: actions/checkout@v4
17+
18+
# Set up Node
19+
- name: Use Node.js 18
20+
uses: actions/setup-node@v3
21+
with:
22+
node-version: 18
23+
24+
# Run install dependencies
25+
- name: Install dependencies
26+
run: npm ci
27+
28+
- name: Check cycles
29+
run : npm run check-cycles

0 commit comments

Comments
 (0)