odo push --debug does not work for nodejs devfile components

[mohitsuman]

This code breaks the workflow when we need to push a nodejs devfile to a cluster.

vscode-openshift-tools/src/odo/command.ts

Line 207 in 132dc1a

return `odo push --debug${configOnly ? ' --config' : ''}`;

All the nodejs demos are breaking with odo push --debug command. It should be odo push.

[dgolovin]

Cannot replicate

This code breaks the workflow when we need to push a nodejs devfile to a cluster.

What it breaks exactly?

vscode-openshift-tools/src/odo/command.ts

Line 207 in 132dc1a

return `odo push --debug${configOnly ? ' --config' : ''}`;

All the nodejs demos are breaking with odo push --debug command. It should be odo push.

What is the error?

[mohitsuman]

When we push the components, the push command is successful but the application is not loading up with the route. If I try with odo push command manually, the push is successful and application is loaded in that specific route.

Devfile nodejs component example app: https://github.com/mohitsuman/react-web-app

[dgolovin]

Does not work for me ether way. Your package.json has no debug script to work with odo push --debug.

[dgolovin]

Target port should be 8080 for URL to work.

[dgolovin]

You have to figure out how to run you add in debug mode and inject debug port for odo to work correctly.
Similar to what nodejs devfile has

"scripts": {
    "start": "node server.js",
    "debug": "node --inspect=${DEBUG_PORT} server.js",
    "test": "node test/test.js"
  }

[dgolovin]

And that is an odo issue not reporting the missing debug script when calling odo push --debug.