When "Import from Git" fails, the repo remains cloned on your computer

[datho7561]

When using the "Import from Git" workflow, if the clone step "fails", such as #2939, the repo remains on the user's disk.

This is unintuitive, since you haven't completed the wizard, and it says that the git url couldn't be parsed.

I think this could be prevented by cleaning up the folder that is being cloned into if the operation truly fails, and providing a way to select a devfile in cases such as #2939

[msivasubramaniaan]

We were kill the git process and deleted the directory on below aspects.

vscode-openshift-tools/src/webview/git-import/gitImportLoader.ts

Line 189 in be34e3f

await deleteDirectory(selctedFolder.fsPath);

1. When user cancel the git import flow
2. When we unable to delete the v1 devfile if already in the repo

   vscode-openshift-tools/src/webview/git-import/gitImportLoader.ts

   Line 233 in be34e3f

   closeWithMessage('Failed to delete devfile.yaml, Unable to proceed the component creation', clonedFolder);

3. When unable to parse the v1 devfile

   vscode-openshift-tools/src/webview/git-import/gitImportLoader.ts

   Line 236 in be34e3f

   closeWithMessage('Failed to parse devfile v1, Unable to proceed the component creation', clonedFolder);

I hope we have handled all the possible cases. Post merging the #2943 we can address the #2939 as well and that scenario as well handled now.

Let me know is there any more scenario we missed.

[msivasubramaniaan]

@datho7561 Please revalidate this one

[datho7561]

Closed by #2943 and #2991