Remove recursive search from binary component selection#1115
Merged
mohitsuman merged 1 commit intoredhat-developer:masterfrom Sep 4, 2019
Merged
Remove recursive search from binary component selection#1115mohitsuman merged 1 commit intoredhat-developer:masterfrom
mohitsuman merged 1 commit intoredhat-developer:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1115 +/- ##
==========================================
+ Coverage 84.11% 84.12% +<.01%
==========================================
Files 31 31
Lines 2147 2148 +1
Branches 375 376 +1
==========================================
+ Hits 1806 1807 +1
Misses 341 341
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1115 +/- ##
==========================================
+ Coverage 84.11% 84.12% +<.01%
==========================================
Files 31 31
Lines 2147 2148 +1
Branches 375 376 +1
==========================================
+ Hits 1806 1807 +1
Misses 341 341
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching for jar/war files recursively doesn't make much sense when you specifically select the folder they are in. And it is especially insane when searching from, say, the user home (that actually crashed vscode after it reached ~8GB of memory allocated).
Also, the URI style path didn't work for windows, so I just took the standard fsPath and replaced backslashes with forward ones.