Skip to content

git+binary workflow fix#1158

Merged
mohitsuman merged 4 commits intoredhat-developer:masterfrom
mohitsuman:gh-1140
Sep 13, 2019
Merged

git+binary workflow fix#1158
mohitsuman merged 4 commits intoredhat-developer:masterfrom
mohitsuman:gh-1140

Conversation

@mohitsuman
Copy link
Copy Markdown
Contributor

@mohitsuman mohitsuman commented Sep 13, 2019

  1. Add context folder selection at start for git workflow
  2. Use workspace.ts for folderSelection for git & binary workflow
  3. Check for component folder already existing at the selected path.

Fix #1159

2. Check for component folder already existing
Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling file inside util module as workspaceUtil.ts is too much 'util' ;)
Have you checked workspace.ts BTW?

@mohitsuman
Copy link
Copy Markdown
Contributor Author

Calling file inside util module as workspaceUtil.ts is too much 'util' ;)
Have you checked workspace.ts BTW?

workspace.ts is renamed as workspaceUtil. As class workspace from vscode was conflicting.

Comment thread src/util/workspaceUtil.ts Outdated
@mohitsuman mohitsuman changed the title git workflow fix git+ binary workflow fix Sep 13, 2019
@mohitsuman mohitsuman changed the title git+ binary workflow fix git+binary workflow fix Sep 13, 2019
@mohitsuman mohitsuman requested a review from dgolovin September 13, 2019 20:31
Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohitsuman mohitsuman merged commit 79e3a49 into redhat-developer:master Sep 13, 2019
@mohitsuman mohitsuman deleted the gh-1140 branch June 16, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

context folder selection for git based workflow

2 participants