Skip to content

Fix clone the git repository while creating Component. #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohitsuman merged 2 commits into from
Sep 17, 2019
Merged

Fix clone the git repository while creating Component. #1169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e801bb
Fix clone the git repository while creating Component.
sudhirverma Sep 17, 2019
3912710
Fix review changes
sudhirverma Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/openshift/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,10 +448,8 @@ export class Component extends OpenShiftItem {

if (!componentTypeVersion) return null;

window.showInformationMessage('Do you want to clone git repository for created Component?', 'Yes', 'No').then((value) => {
value === 'Yes' && commands.executeCommand('git.clone', repoURI);
});

const response = await window.showInformationMessage('Do you want to clone git repository for created Component?', 'Yes', 'No');
if (response === 'Yes') await commands.executeCommand('git.clone', repoURI);
await Component.odo.createComponentFromGit(application, componentTypeName, componentTypeVersion, componentName, repoURI, workspacePath, gitRef.label);
return `Component '${componentName}' successfully created`;
}
Expand Down
⚡