Add json output for catalog list services#1211
Merged
dgolovin merged 2 commits intoredhat-developer:masterfrom Oct 2, 2019
Merged
Add json output for catalog list services#1211dgolovin merged 2 commits intoredhat-developer:masterfrom
dgolovin merged 2 commits intoredhat-developer:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1211 +/- ##
==========================================
+ Coverage 81.86% 81.89% +0.03%
==========================================
Files 32 32
Lines 2266 2270 +4
Branches 403 402 -1
==========================================
+ Hits 1855 1859 +4
Misses 411 411
Continue to review full report at Codecov.
|
sudhirverma
force-pushed
the
724
branch
2 times, most recently
from
151b92e to
2ed602c
Compare
sudhirverma
changed the title
dgolovin
approved these changes
Oct 2, 2019
| // ignore | ||
| } catch (ignore) { | ||
| } | ||
| const stpObject: Array<any> = items.filter((value) => value.metadata.name === svcName); |
Collaborator
There was a problem hiding this comment.
No need filter and map when you can just search. It means less iterations over array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #724