Skip to content

Add terminal names for commands started form k8s Clusters View #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgolovin merged 1 commit into from
May 1, 2020
Merged

Add terminal names for commands started form k8s Clusters View #1529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/k8s/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ export class Build {

@vsCommand('clusters.openshift.build.showLog', true)
static async showLog(context: { impl: any}): Promise<string> {
const build = await Build.selectBuild(context, "Select a build to see the logs");
const build = await Build.selectBuild(context, "Select a Build to see the logs");
if (build) {
Build.odo.executeInTerminal(Build.command.showLog(build, '-build'));
Build.odo.executeInTerminal(Build.command.showLog(build, '-build'), undefined, `OpenShift: Show '${build}' Build Log`);
}
return null;
}
Expand All @@ -102,13 +102,13 @@ export class Build {
if (context) {
resourceId = context.impl.name;
} else {
const name = await Build.selectBuild(context, "select to rebuild");
const name = await Build.selectBuild(context, "Select build to rebuild");
if (name) {
resourceId = name;
}
}
if (resourceId) {
Build.odo.executeInTerminal(Build.command.rebuildFrom(resourceId));
Build.odo.executeInTerminal(Build.command.rebuildFrom(resourceId), undefined, `OpenShift: Rebuild '${resourceId}' Build`);
}
return null;
}
Expand All @@ -117,7 +117,7 @@ export class Build {
static async followLog(context: { impl: any}): Promise<string> {
const build = await Build.selectBuild(context, "Select a build to follow the logs");
if (build) {
Build.odo.executeInTerminal(Build.command.followLog(build, '-build'));
Build.odo.executeInTerminal(Build.command.followLog(build, '-build'), undefined, `OpenShift: Follow '${build}' Build Log`);
}
return null;
}
Expand Down
4 changes: 2 additions & 2 deletions src/k8s/deployment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class DeploymentConfig {
static async rcShowLog(context: { impl: any }): Promise<string> {
const replica = await DeploymentConfig.selectReplica(context, "Select a Replica to see the logs");
if (replica) {
DeploymentConfig.odo.executeInTerminal(DeploymentConfig.command.showLog(replica));
DeploymentConfig.odo.executeInTerminal(DeploymentConfig.command.showLog(replica), undefined, `OpenShift: Show '${replica}' Replica Log`);
}
return replica;
}
Expand All @@ -93,7 +93,7 @@ export class DeploymentConfig {
let deployName: string = context ? context.name : null;
if (!deployName) deployName = await common.selectResourceByName(DeploymentConfig.getDeploymentConfigNames("You have no DeploymentConfigs available to see logs"), "Select a DeploymentConfig to see logs");
if (deployName) {
DeploymentConfig.odo.executeInTerminal(DeploymentConfig.command.showDeploymentConfigLog(deployName));
DeploymentConfig.odo.executeInTerminal(DeploymentConfig.command.showDeploymentConfigLog(deployName), undefined, `OpenShift: Show '${deployName}' DeploymentConfig Log`);
}
return deployName;
}
Expand Down
⚡