Skip to content

add crc webview check for che/theia#1752

Merged
dgolovin merged 4 commits intoredhat-developer:masterfrom
mohitsuman:gh-1751
Sep 22, 2020
Merged

add crc webview check for che/theia#1752
dgolovin merged 4 commits intoredhat-developer:masterfrom
mohitsuman:gh-1751

Conversation

@mohitsuman
Copy link
Copy Markdown
Contributor

Signed-off-by: Mohit Suman mohit.skn@gmail.com

Fix #1751

Signed-off-by: Mohit Suman <mohit.skn@gmail.com>
@mohitsuman mohitsuman requested a review from dgolovin September 17, 2020 22:27
@mohitsuman
Copy link
Copy Markdown
Contributor Author

@dgolovin Please review and merge.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 17, 2020

Codecov Report

Merging #1752 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1752   +/-   ##
=======================================
  Coverage   78.71%   78.72%           
=======================================
  Files          40       40           
  Lines        2626     2627    +1     
  Branches      456      456           
=======================================
+ Hits         2067     2068    +1     
  Misses        559      559           
Impacted Files Coverage Δ
src/extension.ts 81.66% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea41dc...db4643c. Read the comment docs.

Signed-off-by: Mohit Suman <mohit.skn@gmail.com>
Signed-off-by: Mohit Suman <mohit.skn@gmail.com>
Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread src/debug.ts Outdated
Comment thread src/watch.ts Outdated
Signed-off-by: Denis Golovin dgolovin@redhat.com
@dgolovin dgolovin merged commit ac9d5c1 into redhat-developer:master Sep 22, 2020
@mohitsuman mohitsuman deleted the gh-1751 branch June 16, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run CRC webview only in vscode and not on Che instance

2 participants