Fix initialization of error prop in telemetry event#1961
Merged
dgolovin merged 3 commits intoredhat-developer:masterfrom Feb 16, 2021
Merged
Fix initialization of error prop in telemetry event#1961dgolovin merged 3 commits intoredhat-developer:masterfrom
dgolovin merged 3 commits intoredhat-developer:masterfrom
Conversation
This PR fixes redhat-developer#1959. It fixes error property initialization for command telemetry event and introduces telemetryMessage to VsCommandException class to provide messages without user sensitive information. When VsCommandException is triggered the exception's message shown in vscode Error message notification and telemetryMessage sent in telemetry event `error` property. All unknown exceptions are always reported to user by vscode and as 'Unknown exception happened' in telemetry event error property. The fix also introduces 'cancelled' property to indicate if command was cancelled by user. Signed-off-by: Denis Golovin dgolovin@redhat.com
Codecov Report
@@ Coverage Diff @@
## master #1961 +/- ##
==========================================
+ Coverage 81.04% 81.12% +0.08%
==========================================
Files 43 43
Lines 2843 2850 +7
Branches 531 533 +2
==========================================
+ Hits 2304 2312 +8
+ Misses 539 538 -1
Continue to review full report at Codecov.
|
Stack trace removes local folder root location from files in the stack trace. Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
dgolovin
added a commit
that referenced
this pull request
Feb 17, 2021
Fixes #1961 Signed-off-by: Denis Golovin dgolovin@redhat.com
dgolovin
added a commit
that referenced
this pull request
Feb 17, 2021
Fixes #1961 Signed-off-by: Denis Golovin dgolovin@redhat.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1959. It fixes error property initialization
for command telemetry event and introduces telemetryMessage
to VsCommandException class to provide messages without
user sensitive information. When VsCommandException is
triggered the exception's message shown in vscode Error
message notification and telemetryMessage sent in telemetry
event
errorproperty. All unknown exceptions are alwaysreported to user by vscode and as 'Unknown exception happened'
in telemetry event error property. The fix also introduces
'cancelled' property to indicate if command was cancelled
by user.
Signed-off-by: Denis Golovin dgolovin@redhat.com