Skip to content

Set 'loggedIn' context to true only after server url is detected#1991

Merged
dgolovin merged 4 commits intoredhat-developer:masterfrom
dgolovin:i1990
Feb 24, 2021
Merged

Set 'loggedIn' context to true only after server url is detected#1991
dgolovin merged 4 commits intoredhat-developer:masterfrom
dgolovin:i1990

Conversation

@dgolovin
Copy link
Copy Markdown
Collaborator

This PR fixes #1990.

Signed-off-by: Denis Golovin dgolovin@redhat.com

This PR fixes redhat-developer#1990.

Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2021

Codecov Report

Merging #1991 (cfe9a16) into master (9b80267) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1991      +/-   ##
==========================================
- Coverage   80.56%   80.33%   -0.24%     
==========================================
  Files          43       43              
  Lines        2851     2837      -14     
  Branches      532      531       -1     
==========================================
- Hits         2297     2279      -18     
- Misses        554      558       +4     
Impacted Files Coverage Δ
src/odo.ts 74.87% <100.00%> (-0.59%) ⬇️
src/odo/command.ts 91.53% <0.00%> (-3.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b80267...ab9090f. Read the comment docs.

@dgolovin dgolovin merged commit 4a79f84 into redhat-developer:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'LoggedIn` context set incorrectly to 'true' even if cluster is not accessible or user not logged in

1 participant