Create 'Component Types' View#1994
Merged
dgolovin merged 9 commits intoredhat-developer:masterfrom Feb 26, 2021
Merged
Conversation
This PR fixes redhat-developer#1931. Signed-off-by: Denis Golovin dgolovin@redhat.com
Tree implementation with Refresh command. Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Fix adds content to Component Types View. Icons for tree items representing: * S2I Component * S2I ImageStream Tag * Devfile Component * Starter project Fix reqisters new command to open Sample/Starter project repository in browser. Signed-off-by: Denis Golovin dgolovin@redhat.com
Fix adds command to clone sample project repository to workspace. Command is available for ImageStream tag items and Starter project items in Component Types View. Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Codecov Report
@@ Coverage Diff @@
## master #1994 +/- ##
==========================================
- Coverage 80.33% 78.42% -1.91%
==========================================
Files 43 45 +2
Lines 2837 2953 +116
Branches 531 555 +24
==========================================
+ Hits 2279 2316 +37
- Misses 558 637 +79
Continue to review full report at Codecov.
|
Signed-off-by: Denis Golovin dgolovin@redhat.com
This fix adds 'New Component' command fo ImageStreamTag, DevfileComponentType and StarterProject tree items in Component Types View. Depending on context 'New Component' command is skipping certain steps of regular workflow, because some of information like component type kind, name, version and starter project can be extracted from context. It also keep in place existing checks. For example `New Component` command executed on StarterProject will not use starter project in case not empty context folder selected and etc. Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1931.