Components View first iteration#2012
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2012 +/- ##
==========================================
- Coverage 77.13% 76.01% -1.13%
==========================================
Files 45 47 +2
Lines 3026 3143 +117
Branches 579 603 +24
==========================================
+ Hits 2334 2389 +55
- Misses 692 754 +62
Continue to review full report at Codecov.
|
|
Works in general, there are a few things I think should be improved:
|
That is intentional. Imagine you have a project and want to try to deploy it to cluster. Then you delete component and your working project is gone from workspace as well.
That is a good catch.
We will get to it, for now the purpose is to let to see components without being connected/loggedin to cluster
Not sure if that is possible, will check
I noticed that to, but the same command is used in git sidebar for staged resources, that how I found it accidentally. Will check if calling it twice, solves the problem. |
|
Added refresh after deleting and reveal in explorer. |
I understand the need to keep the folders open. But the way this is currently implemented, I can delete a project with X components and still be left with those X components in the view, because their folders still contain the |
df55116 to
67e8ff3
Compare
This PR fixes redhat-developer#2008. This fix adds: 1. Components View (View) under Application Explorer 2. View shows components discovered in workspace root folders 3. Detection for devfile components based on odo env view, which works when cluster is not accessible or user is logged off from cluster 4. Detection for s2i components based on parsing .odo/config.yaml (forkaround for odo env view not working for s2i components) 5. Refresh for View based after event about new folder added to workspace 6. Refrehs for View after component created form existing workspace folder (to avoid using watch for every folder in workspace) 7. Reveal in Explorer for components to activate Explorer view and select context folder (not always working correctly first time, have no idea why) Not implemented yet: 1. Show folders/files under component node (requires some work to incorporate filesystem watching with exlusion for folders like 'node_modules' 2. Watching for filesystem changes or focus ganed event to detect changes done in vscode terminal or external terminal 3. Showing hierarchy Project/Application/Component rather than flat list 4. Support pushing components to cluster from the view, especially for components with project that does not exist or currently not active 5. Showing state Pushed/Not pushed for components pushed to current cluster/namespace (or current context) 6. No icons yet 7. No view Welcome page with 'Create Component' button 8. No support to create component when there is no accessible cluster or user is logged off (there should be quick input requests for project and application names, there should be qiuickpiks provided that allow to select existing and not existing projects/applications) Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
This PR fixes #2008.
This fix adds:
when cluster is not accessible or user is logged off from cluster
(forkaround for odo env view not working for s2i components)
workspace
folder (to avoid using watch for every folder in workspace)
select context folder (not always working correctly first time, have
no idea why)
user is logged off (there should be quick input requests for project
and application names, there should be qiuickpiks provided that allow
to select existing and not existing projects/applications)
Not implemented yet:
incorporate filesystem watching with exlusion for folders like
'node_modules'
changes done in vscode terminal or external terminal
components with project that does not exist or currently not active
cluster/namespace (or current context)
Signed-off-by: Denis Golovin dgolovin@redhat.com