Skip to content

Detect s2i component by sourceType which is set only for s2i comps#2147

Merged
dgolovin merged 1 commit intoredhat-developer:masterfrom
dgolovin:i2146-detect-s2i-component-by-source-type
May 18, 2021
Merged

Detect s2i component by sourceType which is set only for s2i comps#2147
dgolovin merged 1 commit intoredhat-developer:masterfrom
dgolovin:i2146-detect-s2i-component-by-source-type

Conversation

@dgolovin
Copy link
Copy Markdown
Collaborator

This PR fixes #2146.

Signed-off-by: Denis Golovin dgolovin@redhat.com

This PR fixes redhat-developer#2146.

Signed-off-by: Denis Golovin dgolovin@redhat.com
@codecov
Copy link
Copy Markdown

codecov bot commented May 18, 2021

Codecov Report

Merging #2147 (03b88c9) into master (fc8cc8e) will decrease coverage by 0.00%.
The diff coverage is 70.00%.

❗ Current head 03b88c9 differs from pull request most recent head c1bcce2. Consider uploading reports for the commit c1bcce2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2147      +/-   ##
==========================================
- Coverage   76.48%   76.47%   -0.01%     
==========================================
  Files          48       48              
  Lines        3241     3244       +3     
  Branches      614      616       +2     
==========================================
+ Hits         2479     2481       +2     
- Misses        762      763       +1     
Impacted Files Coverage Δ
src/odo.ts 74.63% <66.66%> (ø)
src/odo/command.ts 88.70% <66.66%> (-0.43%) ⬇️
src/openshift/component.ts 82.54% <75.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87cdd7...c1bcce2. Read the comment docs.

@dgolovin dgolovin merged commit ed9297c into redhat-developer:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating new s2i component without version added as devfile kind

1 participant