Skip to content

Do not fail to activate extension when watcher installation fails#2185

Merged
dgolovin merged 2 commits intoredhat-developer:masterfrom
dgolovin:i2184-does-not-fail-actiwation-when-watch-fails
Jul 1, 2021
Merged

Do not fail to activate extension when watcher installation fails#2185
dgolovin merged 2 commits intoredhat-developer:masterfrom
dgolovin:i2184-does-not-fail-actiwation-when-watch-fails

Conversation

@dgolovin
Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin commented Jul 1, 2021

This PR fixes #2184.

Signed-off-by: Denis Golovin dgolovin@redhat.com

This PR fixes redhat-developer#2184.

Signed-off-by: Denis Golovin dgolovin@redhat.com
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2021

Codecov Report

Merging #2185 (bda799b) into master (c1baa42) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

❗ Current head bda799b differs from pull request most recent head f93fd1e. Consider uploading reports for the commit f93fd1e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2185      +/-   ##
==========================================
- Coverage   76.50%   76.48%   -0.02%     
==========================================
  Files          48       48              
  Lines        3294     3296       +2     
  Branches      628      630       +2     
==========================================
+ Hits         2520     2521       +1     
- Misses        774      775       +1     
Impacted Files Coverage Δ
src/explorer.ts 80.32% <60.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1baa42...f93fd1e. Read the comment docs.

Signed-off-by: Denis Golovin dgolovin@redhat.com
@dgolovin dgolovin merged commit e666423 into redhat-developer:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension fails to load if limit of FSWatchers is reached

1 participant