Skip to content

Rename kind property to avoid conflict with proposed API#2315

Merged
dgolovin merged 4 commits intoredhat-developer:masterfrom
dgolovin:master
Dec 10, 2021
Merged

Rename kind property to avoid conflict with proposed API#2315
dgolovin merged 4 commits intoredhat-developer:masterfrom
dgolovin:master

Conversation

@dgolovin
Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin commented Dec 10, 2021

Fixes #2316.

Signed-off-by: Denis Golovin dgolovin@redhat.com

Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 10, 2021

Codecov Report

Merging #2315 (3c8d5ef) into master (1b90a6f) will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2315   +/-   ##
=======================================
  Coverage   70.10%   70.10%           
=======================================
  Files          51       51           
  Lines        3399     3399           
  Branches      627      627           
=======================================
  Hits         2383     2383           
  Misses       1016     1016           
Impacted Files Coverage Δ
src/odo/componentType.ts 86.36% <66.66%> (ø)
src/openshift/component.ts 81.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b90a6f...3c8d5ef. Read the comment docs.

@dgolovin dgolovin merged commit b787b09 into redhat-developer:master Dec 10, 2021
dgolovin added a commit that referenced this pull request Dec 14, 2021
Signed-off-by: Denis Golovin dgolovin@redhat.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ComponentAdapter kind field conflicts with VSCode 1.63.0 proposed API

1 participant