Skip to content

Don't filter workspace folders with s2i comps from context quickpick#2447

Merged
dgolovin merged 1 commit intoredhat-developer:mainfrom
dgolovin:i2446-ignore-s2i-component-folders
Jun 8, 2022
Merged

Don't filter workspace folders with s2i comps from context quickpick#2447
dgolovin merged 1 commit intoredhat-developer:mainfrom
dgolovin:i2446-ignore-s2i-component-folders

Conversation

@dgolovin
Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin commented Jun 2, 2022

This PR fixes #2446.

Signed-off-by: Denis Golovin dgolovin@redhat.com

This PR fixes redhat-developer#2446.

Signed-off-by: Denis Golovin dgolovin@redhat.com
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 2, 2022

Codecov Report

Merging #2447 (35475fe) into main (49e11dc) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2447      +/-   ##
==========================================
- Coverage   66.64%   66.62%   -0.03%     
==========================================
  Files          55       55              
  Lines        3586     3583       -3     
  Branches      648      647       -1     
==========================================
- Hits         2390     2387       -3     
  Misses       1196     1196              
Impacted Files Coverage Δ
src/util/workspace.ts 96.29% <100.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e11dc...35475fe. Read the comment docs.

@dgolovin dgolovin merged commit ccc7750 into redhat-developer:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Component workflow select context folder step should not filter out workspace folders with s2i components

1 participant