performance improvement of getting devfile registries

[msivasubramaniaan]

Signed-off-by: msivasubramaniaan msivasub@redhat.com

Fix #2496

[dgolovin]

Please set indentation to 4 spaces.

[msivasubramaniaan]

Please set indentation to 4 spaces.

yes I have the same settings only

[dgolovin]

Better, but still need some work in several places.

1. I agree we can keep component descriptors array in ComponentTypesView class instance.
2. Your implementation works, but it is not easy to understand and I don't think it is good idea to use subscriber to send events from member function to the same class instance when you can just use this.

You have ComponentTypesView instance and RegistryViewLoader instance. I would suggest to get rid of rxjs and use EventEmitter to nodify ComponentTypesView clients (RegistryViewer in this case) about component description update and the need to refresh.

[msivasubramaniaan]

Better, but still need some work in several places.

1. I agree we can keep component descriptors array in ComponentTypesView class instance.
2. Your implementation works, but it is not easy to understand and I don't think it is good idea to use subscriber to send events from member function to the same class instance when you can just use this.

You have ComponentTypesView instance and RegistryViewLoader instance. I would suggest to get rid of rxjs and use EventEmitter to nodify ComponentTypesView clients (RegistryViewer in this case) about component description update and the need to refresh.

As discussed using subject for only sending notification on refresh the screen.

[mohitsuman]

LGTM wrt to the UI part of it with loader and icon. Once @dgolovin is fine with the code workflow, we can merge.

[dgolovin]

One last change is needed.

[codecov]

Codecov Report

Merging #2495 (d608d58) into main (30bf2bb) will increase coverage by 0.57%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #2495      +/-   ##
==========================================
+ Coverage   66.58%   67.15%   +0.57%     
==========================================
  Files          55       55              
  Lines        3585     3626      +41     
  Branches      649      659      +10     
==========================================
+ Hits         2387     2435      +48     
+ Misses       1198     1191       -7     

Impacted Files	Coverage Δ
src/odo.ts	69.67% <ø> (+1.21%)	⬆️
src/registriesView.ts	31.75% <40.00%> (+3.30%)	⬆️
src/webview/devfile-registry/registryViewLoader.ts	27.63% <66.66%> (+8.80%)	⬆️
src/util/kubeUtils.ts	87.71% <90.00%> (+2.00%)	⬆️
src/extension.ts	83.58% <100.00%> (+0.24%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.