Skip to content

2402 design a welcome page with instructions and feature sets#2537

Merged
mohitsuman merged 47 commits intoredhat-developer:mainfrom
msivasubramaniaan:2402-design-a-welcome-page-with-instructions-and-feature-sets
Sep 22, 2022
Merged

2402 design a welcome page with instructions and feature sets#2537
mohitsuman merged 47 commits intoredhat-developer:mainfrom
msivasubramaniaan:2402-design-a-welcome-page-with-instructions-and-feature-sets

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

Signed-off-by: msivasubramaniaan msivasub@redhat.com

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 7, 2022

Codecov Report

Base: 67.13% // Head: 67.08% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (1c11414) compared to base (0fe8c2c).
Patch coverage: 68.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2537      +/-   ##
==========================================
- Coverage   67.13%   67.08%   -0.06%     
==========================================
  Files          55       56       +1     
  Lines        3630     3679      +49     
  Branches      660      671      +11     
==========================================
+ Hits         2437     2468      +31     
- Misses       1193     1211      +18     
Impacted Files Coverage Δ
src/webview/welcome/welcomeViewLoader.ts 66.66% <66.66%> (ø)
src/welcomePage.ts 88.88% <85.71%> (-11.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link
Copy Markdown
Contributor

@mohitsuman mohitsuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the unused component.svg and devfile .svg images. I have added the other description texts to be updated as suggestions.

Comment thread src/welcomePage.ts Outdated
Comment thread src/webview/welcome/app/welcomePage.tsx Outdated
Comment thread src/webview/welcome/app/welcomePage.tsx Outdated
Comment thread src/webview/welcome/app/welcomePage.tsx Outdated
Comment thread src/webview/welcome/app/welcomePage.tsx Outdated
Comment thread src/webview/welcome/app/welcomePage.tsx Outdated
Comment thread src/webview/welcome/app/welcomePage.tsx Outdated
Comment thread src/webview/welcome/app/welcomePage.tsx Outdated
Comment thread src/webview/welcome/app/welcomePage.tsx Outdated
Comment thread src/webview/welcome/app/welcomePage.tsx Outdated
msivasubramaniaan and others added 18 commits September 12, 2022 15:05
Title Changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
footer link name changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
footer link name changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
footer link name changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
footer link name changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
extension section changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
footer link name changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
footer link name changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
extension name changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
extension name changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
extension name changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
footer link changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
footer link changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
extension name changed

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Comment thread src/webview/welcome/app/welcomePage.tsx Outdated
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@mohitsuman mohitsuman merged commit f16fa46 into redhat-developer:main Sep 22, 2022
@msivasubramaniaan msivasubramaniaan deleted the 2402-design-a-welcome-page-with-instructions-and-feature-sets branch January 3, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design a new Welcome Page with Instructions and Feature sets

2 participants