Conversation
Codecov ReportBase: 23.21% // Head: 23.21% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2609 +/- ##
=======================================
Coverage 23.21% 23.21%
=======================================
Files 16 16
Lines 978 978
Branches 127 127
=======================================
Hits 227 227
Misses 751 751
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dgolovin
requested changes
Nov 1, 2022
Collaborator
dgolovin
left a comment
dgolovin
left a comment
There was a problem hiding this comment.
If you changing preference ids, there should be migration code that takes old preferences and move them to preferences with new ids.
Collaborator
|
@mohitsuman should change only displayName to avoid writing migration code |
dgolovin
requested changes
Nov 4, 2022
Collaborator
dgolovin
left a comment
dgolovin
left a comment
There was a problem hiding this comment.
Extension ID should stay the same.
Signed-off-by: Mohit Suman <mohit.skn@gmail.com>
Signed-off-by: Denis Golovin dgolovin@redhat.com
dgolovin
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohit Suman mohit.skn@gmail.com
Fix #2591