Skip to content

fixed selection issue when more than one registry devfile available#2675

Merged
mohitsuman merged 1 commit intoredhat-developer:mainfrom
msivasubramaniaan:2674-unable-to-select-devfile-registry-in-git-import-when-multiple-devfile-registry-configured
Nov 25, 2022
Merged

fixed selection issue when more than one registry devfile available#2675
mohitsuman merged 1 commit intoredhat-developer:mainfrom
msivasubramaniaan:2674-unable-to-select-devfile-registry-in-git-import-when-multiple-devfile-registry-configured

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

Signed-off-by: msivasubramaniaan msivasub@redhat.com

Post Fix:
git-import-create-component-multiple-registries

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 17, 2022

Codecov Report

Base: 34.54% // Head: 34.53% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (aa9cfd6) compared to base (4ff5302).
Patch coverage: 45.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2675      +/-   ##
==========================================
- Coverage   34.54%   34.53%   -0.02%     
==========================================
  Files          68       68              
  Lines        4012     4019       +7     
  Branches      712      714       +2     
==========================================
+ Hits         1386     1388       +2     
- Misses       2626     2631       +5     
Impacted Files Coverage Δ
src/webview/git-import/gitImportLoader.ts 18.95% <0.00%> (-0.13%) ⬇️
src/webview/devfile-registry/registryViewLoader.ts 28.04% <50.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@mohitsuman mohitsuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohitsuman mohitsuman merged commit 8382031 into redhat-developer:main Nov 25, 2022
dgolovin pushed a commit to msivasubramaniaan/vscode-openshift-tools that referenced this pull request Nov 29, 2022
…edhat-developer#2675)

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@dgolovin dgolovin mentioned this pull request Nov 29, 2022
@msivasubramaniaan msivasubramaniaan deleted the 2674-unable-to-select-devfile-registry-in-git-import-when-multiple-devfile-registry-configured branch January 3, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to select devfile registry in git import when multiple devfile registry configured

2 participants