Skip to content

2681 cancel git clone process if user exits import from git workflow#2692

Merged
dgolovin merged 9 commits intoredhat-developer:mainfrom
msivasubramaniaan:2681-cancel-git-clone-process-if-user-exists-import-from-git-workflow
Jan 7, 2023
Merged

2681 cancel git clone process if user exits import from git workflow#2692
dgolovin merged 9 commits intoredhat-developer:mainfrom
msivasubramaniaan:2681-cancel-git-clone-process-if-user-exists-import-from-git-workflow

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

Signed-off-by: msivasubramaniaan msivasub@redhat.com

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 2, 2022

Codecov Report

Base: 34.04% // Head: 33.99% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (8081343) compared to base (d6f7b8e).
Patch coverage: 14.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2692      +/-   ##
==========================================
- Coverage   34.04%   33.99%   -0.06%     
==========================================
  Files          69       69              
  Lines        4141     4162      +21     
  Branches      738      757      +19     
==========================================
+ Hits         1410     1415       +5     
- Misses       2731     2747      +16     
Impacted Files Coverage Δ
src/webview/git-import/gitImportLoader.ts 19.54% <14.28%> (+0.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mohitsuman
Copy link
Copy Markdown
Contributor

This will Fix #2681

@dgolovin dgolovin changed the title 2681 cancel git clone process if user exists import from git workflow 2681 cancel git clone process if user exits import from git workflow Jan 4, 2023
Comment thread src/webview/git-import/gitImportLoader.ts Outdated
dgolovin
dgolovin previously approved these changes Jan 4, 2023
@dgolovin dgolovin dismissed their stale review January 4, 2023 23:28

mistake

Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about deleting directory.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Comment thread src/webview/git-import/gitImportLoader.ts Outdated
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@dgolovin dgolovin merged commit e224b47 into redhat-developer:main Jan 7, 2023
@msivasubramaniaan msivasubramaniaan deleted the 2681-cancel-git-clone-process-if-user-exists-import-from-git-workflow branch March 9, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancel git clone process if user exists Import from Git workflow

3 participants