handled error case if no devfile registry available#2706
Merged
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportBase: 34.37% // Head: 34.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2706 +/- ##
==========================================
- Coverage 34.37% 34.13% -0.25%
==========================================
Files 68 69 +1
Lines 4084 4125 +41
Branches 719 731 +12
==========================================
+ Hits 1404 1408 +4
- Misses 2680 2717 +37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mohitsuman
reviewed
Dec 13, 2022
| panel?.webview.postMessage( | ||
| { | ||
| action: eventActionName, | ||
| errorMessage: 'No Devfile registries configured' |
Contributor
There was a problem hiding this comment.
@msivasubramaniaan Instead of showing the Devfile Webview with this message, we can just load the Error Notification of VSCode saying No devfile registry is accessible.
mohitsuman
reviewed
Dec 13, 2022
Contributor
mohitsuman
left a comment
mohitsuman
left a comment
There was a problem hiding this comment.
Need to see if vscode error message or webview one makes sense.
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
dgolovin
approved these changes
Dec 16, 2022
msivasubramaniaan
deleted the
2705-devfile-registry-view-does-not-show-errors-for-connectivity-related-issues-and-stays-in-loading-registry-view-mode-forever
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: msivasubramaniaan msivasub@redhat.com
Post Fix:
