show error message content if folder already exists and provide option to select new folder until valid#2708
Merged
dgolovin merged 7 commits intoredhat-developer:mainfrom Jan 10, 2023
Conversation
…n to select new folder until valid Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportBase: 33.99% // Head: 33.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2708 +/- ##
==========================================
- Coverage 33.99% 33.75% -0.25%
==========================================
Files 69 69
Lines 4162 4198 +36
Branches 757 765 +8
==========================================
+ Hits 1415 1417 +2
- Misses 2747 2781 +34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mohitsuman
suggested changes
Dec 16, 2022
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
dgolovin
reviewed
Dec 20, 2022
…component Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
dgolovin
requested changes
Dec 23, 2022
Collaborator
dgolovin
left a comment
dgolovin
left a comment
There was a problem hiding this comment.
- What does the icon with exclamation mark means?
- The button 'Create Component' does nothing and it does not look like it is disabled or something.
dgolovin
requested changes
Dec 23, 2022
Collaborator
Author
Hello @dgolovin , Did you test on the latest code? |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
dgolovin
requested changes
Dec 30, 2022
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
dgolovin
previously approved these changes
Jan 9, 2023
…error-message-in-import-from-git-wizard
dgolovin
approved these changes
Jan 10, 2023
msivasubramaniaan
deleted the
2700-missing-word-in-error-message-in-import-from-git-wizard
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: msivasubramaniaan msivasub@redhat.com