change syntax highlighting style based on theme selection#2720
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportBase: 34.05% // Head: 34.04% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2720 +/- ##
==========================================
- Coverage 34.05% 34.04% -0.01%
==========================================
Files 69 69
Lines 4135 4141 +6
Branches 736 738 +2
==========================================
+ Hits 1408 1410 +2
- Misses 2727 2731 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dgolovin
left a comment
There was a problem hiding this comment.
Do not use vscode command for this. The main reason for that is whenever user changes the theme a telemetry event is going to be triggered. This event would not carry any interesting information related to using our tools. If webview based editor required to react to theme change implement it in specific webview based editor for now.
React doesn't have any theme change event as of now. I have two proposal here:
|
…e command Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan msivasub@redhat.com
Post Fix:
