Skip to content

change syntax highlighting style based on theme selection#2720

Merged
dgolovin merged 2 commits intoredhat-developer:mainfrom
msivasubramaniaan:2718-is-it-possible-to-change-the-colors-of-the-yml-keys
Jan 4, 2023
Merged

change syntax highlighting style based on theme selection#2720
dgolovin merged 2 commits intoredhat-developer:mainfrom
msivasubramaniaan:2718-is-it-possible-to-change-the-colors-of-the-yml-keys

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

Signed-off-by: msivasubramaniaan msivasub@redhat.com

Post Fix:
image

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan msivasubramaniaan self-assigned this Jan 3, 2023
@msivasubramaniaan msivasubramaniaan linked an issue Jan 3, 2023 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 3, 2023

Codecov Report

Base: 34.05% // Head: 34.04% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (b694220) compared to base (24feb72).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2720      +/-   ##
==========================================
- Coverage   34.05%   34.04%   -0.01%     
==========================================
  Files          69       69              
  Lines        4135     4141       +6     
  Branches      736      738       +2     
==========================================
+ Hits         1408     1410       +2     
- Misses       2727     2731       +4     
Impacted Files Coverage Δ
src/extension.ts 60.46% <ø> (ø)
src/webview/devfile-registry/registryViewLoader.ts 26.66% <33.33%> (+0.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use vscode command for this. The main reason for that is whenever user changes the theme a telemetry event is going to be triggered. This event would not carry any interesting information related to using our tools. If webview based editor required to react to theme change implement it in specific webview based editor for now.

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator Author

msivasubramaniaan commented Jan 4, 2023

Do not use vscode command for this. The main reason for that is whenever user changes the theme a telemetry event is going to be triggered. This event would not carry any interesting information related to using our tools. If webview based editor required to react to theme change implement it in specific webview based editor for now.

React doesn't have any theme change event as of now. I have two proposal here:

  1. is there any way to restrict telemetry event for an one particular command?
  2. Instead of using command moved the onDidChangeActiveColorTheme into registryViewLoader.ts and pass theme value using webview. (Like recent code change)

…e command

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@dgolovin dgolovin merged commit 3ca1c49 into redhat-developer:main Jan 4, 2023
@msivasubramaniaan msivasubramaniaan deleted the 2718-is-it-possible-to-change-the-colors-of-the-yml-keys branch March 9, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is it possible to change the colors of the YML keys?

2 participants