Skip to content

re initialize the form values when git url text box updated#2730

Merged
dgolovin merged 1 commit intoredhat-developer:mainfrom
msivasubramaniaan:2726-changing-git-repository-field-after-validation-does-not-invalidate-valid-state-of-the-form
Jan 7, 2023
Merged

re initialize the form values when git url text box updated#2730
dgolovin merged 1 commit intoredhat-developer:mainfrom
msivasubramaniaan:2726-changing-git-repository-field-after-validation-does-not-invalidate-valid-state-of-the-form

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

Signed-off-by: msivasubramaniaan msivasub@redhat.com

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 6, 2023

Codecov Report

Base: 34.04% // Head: 34.04% // No change to project coverage 👍

Coverage data is based on head (4a34b5b) compared to base (d6f7b8e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2730   +/-   ##
=======================================
  Coverage   34.04%   34.04%           
=======================================
  Files          69       69           
  Lines        4141     4141           
  Branches      738      738           
=======================================
  Hits         1410     1410           
  Misses       2731     2731           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now 'Create Component' button is always disabled.

Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve, because the issues is seems to be related to #2727

@dgolovin dgolovin merged commit 6915b47 into redhat-developer:main Jan 7, 2023
@msivasubramaniaan msivasubramaniaan deleted the 2726-changing-git-repository-field-after-validation-does-not-invalidate-valid-state-of-the-form branch March 9, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing git repository field after validation does not invalidate valid state of the form

2 participants