Skip to content

change button color based on enable/disable#2731

Merged
dgolovin merged 1 commit intoredhat-developer:mainfrom
msivasubramaniaan:2725-active-and-disabled-create-component-buttons-look-the-same
Jan 7, 2023
Merged

change button color based on enable/disable#2731
dgolovin merged 1 commit intoredhat-developer:mainfrom
msivasubramaniaan:2725-active-and-disabled-create-component-buttons-look-the-same

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

Signed-off-by: msivasubramaniaan msivasub@redhat.com

Post Fix:

  • On Disabled
    image
  • On Enabled
    image

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 6, 2023

Codecov Report

Base: 34.04% // Head: 34.04% // No change to project coverage 👍

Coverage data is based on head (73f1fba) compared to base (d6f7b8e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2731   +/-   ##
=======================================
  Coverage   34.04%   34.04%           
=======================================
  Files          69       69           
  Lines        4141     4141           
  Branches      738      738           
=======================================
  Hits         1410     1410           
  Misses       2731     2731           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Disabled button is there, but it always stays disabled.

@dgolovin
Copy link
Copy Markdown
Collaborator

dgolovin commented Jan 7, 2023

the problem is if deviles are not available for some reason from registry 'Create Component' button is never gets enabled and there is no messages what is wrong.

@dgolovin
Copy link
Copy Markdown
Collaborator

dgolovin commented Jan 7, 2023

Approving this one, because the problem is not related to this change.

@dgolovin dgolovin merged commit c5ebef7 into redhat-developer:main Jan 7, 2023
@msivasubramaniaan msivasubramaniaan deleted the 2725-active-and-disabled-create-component-buttons-look-the-same branch January 7, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Active and disabled 'Create Component' buttons look the same

2 participants