Skip to content

2658 fix npm install warnings for packages and their dependencies#2748

Merged
rgrunber merged 3 commits intoredhat-developer:mainfrom
msivasubramaniaan:2658-fix-npm-install-warnings-for-packages-and-their-dependencies
Mar 3, 2023
Merged

2658 fix npm install warnings for packages and their dependencies#2748
rgrunber merged 3 commits intoredhat-developer:mainfrom
msivasubramaniaan:2658-fix-npm-install-warnings-for-packages-and-their-dependencies

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3b510ca) 34.18% compared to head (0ad8138) 34.18%.

❗ Current head 0ad8138 differs from pull request most recent head 0b76f2f. Consider uploading reports for the commit 0b76f2f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2748   +/-   ##
=======================================
  Coverage   34.18%   34.18%           
=======================================
  Files          69       69           
  Lines        4227     4227           
  Branches      773      773           
=======================================
  Hits         1445     1445           
  Misses       2782     2782           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The part of the change that updates npm-check-updates looks fine to me.

However it doesn't look like the indentation is done correctly. Try with "editor.renderWhitespace": "all" and you'll see spaces still get mixed in.

The file is mostly using tabs with a size of 4 spaces, so that should probably be used.

@rgrunber rgrunber merged commit 00e5ca1 into redhat-developer:main Mar 3, 2023
@msivasubramaniaan msivasubramaniaan deleted the 2658-fix-npm-install-warnings-for-packages-and-their-dependencies branch March 9, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix npm install warnings for packages and their dependencies

2 participants