Skip to content

integrated ODO analyze#2795

Merged
msivasubramaniaan merged 9 commits intoredhat-developer:mainfrom
msivasubramaniaan:2790-use-odo-analyze-command-to-detect-devfiles-in-import-from-git-workflow
Apr 19, 2023
Merged

integrated ODO analyze#2795
msivasubramaniaan merged 9 commits intoredhat-developer:mainfrom
msivasubramaniaan:2790-use-odo-analyze-command-to-detect-devfiles-in-import-from-git-workflow

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

@msivasubramaniaan msivasubramaniaan commented Mar 17, 2023

Signed-off-by: msivasubramaniaan msivasub@redhat.com

ref: #2790

git-import-create-component-odo-analyze

Devfile v1:
git-import-create-component-odo-analyze-devfile-v1

…he devfile

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 4.56% and project coverage change: -0.37 ⚠️

Comparison is base (97f23a5) 34.17% compared to head (50df1a4) 33.80%.

❗ Current head 50df1a4 differs from pull request most recent head a955ed2. Consider uploading reports for the commit a955ed2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2795      +/-   ##
==========================================
- Coverage   34.17%   33.80%   -0.37%     
==========================================
  Files          70       56      -14     
  Lines        4302     4062     -240     
  Branches      777      774       -3     
==========================================
- Hits         1470     1373      -97     
+ Misses       2832     2689     -143     
Impacted Files Coverage Δ
src/odo/componentType.ts 25.00% <ø> (ø)
src/registriesView.ts 35.03% <ø> (+0.44%) ⬆️
src/webview/git-import/devfileConverter.ts 1.11% <1.11%> (ø)
src/util/workspace.ts 26.31% <5.88%> (-1.47%) ⬇️
src/webview/git-import/gitImportLoader.ts 15.85% <9.52%> (-1.85%) ⬇️
src/odo.ts 31.57% <20.00%> (-0.07%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link
Copy Markdown
Contributor

@mohitsuman mohitsuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few wording changes. I will look at the full workflow and recommend if that looks good.

@msivasubramaniaan if you have a video for the workflow, that would be quick to review.

Comment thread src/util/workspace.ts Outdated
Comment thread src/util/workspace.ts Outdated
Comment thread src/webview/git-import/gitImportLoader.ts Outdated
Comment thread src/webview/git-import/gitImportLoader.ts
Comment thread src/webview/git-import/gitImportLoader.ts Outdated
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link
Copy Markdown
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change works for me. Definitely makes it easier having the recommendation. Feel free to squash + merge when ready.

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator Author

Few wording changes. I will look at the full workflow and recommend if that looks good.

@msivasubramaniaan if you have a video for the workflow, that would be quick to review.

Done

@msivasubramaniaan msivasubramaniaan dismissed mohitsuman’s stale review April 19, 2023 07:48

Resolved his comment already, Due to is non availability I am forcing to dismiss his review and Roland already approved it.

@msivasubramaniaan msivasubramaniaan merged commit 2beabdb into redhat-developer:main Apr 19, 2023
@msivasubramaniaan msivasubramaniaan deleted the 2790-use-odo-analyze-command-to-detect-devfiles-in-import-from-git-workflow branch April 19, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use odo analyze command to detect devfiles in Import From Git workflow

3 participants