If cluster is not up during login, pick new URL#2834
If cluster is not up during login, pick new URL#2834rgrunber merged 1 commit intoredhat-developer:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2834 +/- ##
==========================================
+ Coverage 33.88% 33.90% +0.02%
==========================================
Files 70 70
Lines 4326 4347 +21
Branches 777 781 +4
==========================================
+ Hits 1466 1474 +8
- Misses 2860 2873 +13
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@msivasubramaniaan if you have time, do you mind reviewing this PR? Thank you! |
|
@datho7561 Can you add the video recording for reference? |
cluster-no-started.mp4 |
datho7561
force-pushed
the
709-cluster-not-up
branch
from
87a2ad9 to
1e0e75d
Compare
|
@datho7561 if cluster not accessible it good to show the message but I feel it would be better to show some action that make cluster availability again. WDYT? |
Sure, I think it would be nice to present options to get the cluster running. Here's what I think we could show:
I guess we can figure out from the URL the user entered if either of these apply, then prompt them to take that action. I'll take a look into adding that. |
Yeah. Simply we can redirect to the cluster webview page. |
datho7561
force-pushed
the
709-cluster-not-up
branch
2 times, most recently
from
4d3e9ba to
4c7ac10
Compare
|
Okay cool, I've added a prompts that redirect to the corresponding pages in the "Create Cluster" webview. |
When the user is attempting to login to a cluster, check if the cluster is accessible before prompting for credentials. To check if the cluster is accessible, send a GET request to the cluster API URL; if the API endpoint cannot be found: - if the URL appears to be a CRC api URL, offer to start CRC - if the URL appears to be a Dev Sandbox URL, link to the information page on Dev Sandbox - otherwise, display a warning message and return to the step where the user inputs the cluster URL. This means that if the user tries to login to a cluster that is not running, they don't have to click through the rest of the inputs before receiving this message. Also, if the cluster is not available since the user mistyped the URL, they have the chance to type it in again. Fixes redhat-developer#709 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
709-cluster-not-up
branch
from
4c7ac10 to
853fb5a
Compare
|
@datho7561 change looks fine. Only odd thing I noticed were some rather large delays between entering, say |
Yeah, that's expected unfortunately. It takes a while to figure out the URL is unreachable. |
3 participants
When the user is attempting to login to a cluster, check if the cluster is accessible before prompting for credentials. To check if the cluster is accessible, send a GET request to the cluster API URL; if the API endpoint cannot be found:
This means that if the user tries to login to a cluster that is not running, they don't have to click through the rest of the inputs before receiving this message. Also, if the cluster is not available since the user mistyped the URL, they have the chance to type it in again.
Fixes #709
Signed-off-by: David Thompson davthomp@redhat.com