Skip to content

fix updated Node.js 16 in GH workflow actions#2836

Merged
msivasubramaniaan merged 4 commits intoredhat-developer:mainfrom
msivasubramaniaan:migrate-checkout-v3
Apr 18, 2023
Merged

fix updated Node.js 16 in GH workflow actions#2836
msivasubramaniaan merged 4 commits intoredhat-developer:mainfrom
msivasubramaniaan:migrate-checkout-v3

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

Signed-off-by: msivasubramaniaan msivasub@redhat.com

This PR resolves the following warnings on GH actions
image

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.22 ⚠️

Comparison is base (fbe9731) 34.04% compared to head (7e2a72c) 33.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2836      +/-   ##
==========================================
- Coverage   34.04%   33.83%   -0.22%     
==========================================
  Files          70       70              
  Lines        4326     4347      +21     
  Branches      777      781       +4     
==========================================
- Hits         1473     1471       -2     
- Misses       2853     2876      +23     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan msivasubramaniaan changed the title fix Node.js 12 actions are deprecated in GH workflow actions fix updated Node.js 16 in GH workflow actions Apr 17, 2023
rgrunber
rgrunber previously approved these changes Apr 17, 2023
Copy link
Copy Markdown
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We seem to mostly use checkout without modifying parameters, so that should probably work the same way.

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator Author

LGTM. We seem to mostly use checkout without modifying parameters, so that should probably work the same way.

Seems gabrielbb/xvfb-action was deprecated and used v1 still. Hope we need to update this as well

…p codecov/codecov-action version to 3.1.2

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan
Copy link
Copy Markdown
Collaborator Author

@rgrunber I have moved coactions/setup-xvfb and resolved all the existing warnings. Please refer: https://github.com/redhat-developer/vscode-openshift-tools/actions/runs/4731705085. Hence I would merge this PR and close it.

@msivasubramaniaan msivasubramaniaan merged commit e2e3ea9 into redhat-developer:main Apr 18, 2023
@msivasubramaniaan msivasubramaniaan deleted the migrate-checkout-v3 branch April 18, 2023 11:28
@rgrunber rgrunber added this to the 1.3.0 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants