Skip to content

added null check for starter project#2843

Merged
msivasubramaniaan merged 1 commit intoredhat-developer:mainfrom
msivasubramaniaan:fix-ui-breaks-on-devfile-registry
Apr 20, 2023
Merged

added null check for starter project#2843
msivasubramaniaan merged 1 commit intoredhat-developer:mainfrom
msivasubramaniaan:fix-ui-breaks-on-devfile-registry

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

Signed-off-by: msivasubramaniaan msivasub@redhat.com

This PR resolves the UI breaks of Devfile Registry viewer due to recent addition of https://registry.devfile.io/viewer/devfiles/community/udi. As the devfile not have any starter project.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan msivasubramaniaan self-assigned this Apr 20, 2023
@msivasubramaniaan msivasubramaniaan added this to the 1.3.0 milestone Apr 20, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (8398fdd) 33.45% compared to head (64423f2) 33.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2843      +/-   ##
==========================================
- Coverage   33.45%   33.35%   -0.10%     
==========================================
  Files          56       56              
  Lines        4107     4107              
  Branches      778      778              
==========================================
- Hits         1374     1370       -4     
- Misses       2733     2737       +4     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well! Thanks, Muthu!

@msivasubramaniaan msivasubramaniaan merged commit 90504db into redhat-developer:main Apr 20, 2023
@msivasubramaniaan msivasubramaniaan deleted the fix-ui-breaks-on-devfile-registry branch April 20, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants