Skip to content

Add 'Sign in with Red Hat ...' item to Accounts menu when ext activated#2861

Merged
rgrunber merged 1 commit intoredhat-developer:mainfrom
dgolovin:i2860
May 5, 2023
Merged

Add 'Sign in with Red Hat ...' item to Accounts menu when ext activated#2861
rgrunber merged 1 commit intoredhat-developer:mainfrom
dgolovin:i2860

Conversation

@dgolovin
Copy link
Copy Markdown
Collaborator

Signed-off-by: Denis Golovin dgolovin@redhat.com

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (fc39699) 33.47% compared to head (9842985) 33.49%.

❗ Current head 9842985 differs from pull request most recent head 18af0fb. Consider uploading reports for the commit 18af0fb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2861      +/-   ##
==========================================
+ Coverage   33.47%   33.49%   +0.01%     
==========================================
  Files          56       56              
  Lines        4116     4117       +1     
  Branches      779      779              
==========================================
+ Hits         1378     1379       +1     
  Misses       2738     2738              
Impacted Files Coverage Δ
src/extension.ts 60.91% <100.00%> (+0.45%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mohitsuman mohitsuman requested a review from rgrunber May 4, 2023 15:52
Copy link
Copy Markdown
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After extension activation, I can see the option in the context menu.

sign-in-to-redhat

@rgrunber rgrunber added this to the 1.4.0 milestone May 5, 2023
@rgrunber rgrunber merged commit c8ba29f into redhat-developer:main May 5, 2023
@mohitsuman
Copy link
Copy Markdown
Contributor

@dgolovin @rgrunber Why is there (1) at the end of the text ?

@rgrunber
Copy link
Copy Markdown
Member

rgrunber commented May 5, 2023

Looks like the (1) is used to indicate the element contributes to the badge count (ie. that little badge at the bottom left). There doesn't seem to be a way to disable.

https://github.com/microsoft/vscode/blob/aebaec6cafe65229a264ee6297c1ef03462ffbff/src/vs/workbench/services/authentication/browser/authenticationService.ts#L648-L650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants