Add feedback webview#2925
Merged
msivasubramaniaan merged 20 commits intoredhat-developer:mainfrom Jun 6, 2023
Merged
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2925 +/- ##
==========================================
- Coverage 37.40% 37.31% -0.10%
==========================================
Files 54 56 +2
Lines 3652 3685 +33
Branches 716 723 +7
==========================================
+ Hits 1366 1375 +9
- Misses 2286 2310 +24
☔ View full report in Codecov by Sentry. |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
datho7561
requested changes
Jun 1, 2023
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Contributor
|
mohitsuman
reviewed
Jun 4, 2023
mohitsuman
reviewed
Jun 4, 2023
mohitsuman
reviewed
Jun 4, 2023
mohitsuman
reviewed
Jun 4, 2023
mohitsuman
reviewed
Jun 4, 2023
mohitsuman
reviewed
Jun 4, 2023
mohitsuman
reviewed
Jun 4, 2023
mohitsuman
reviewed
Jun 4, 2023
mohitsuman
reviewed
Jun 4, 2023
Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
mohitsuman
reviewed
Jun 6, 2023
mohitsuman
reviewed
Jun 6, 2023
mohitsuman
reviewed
Jun 6, 2023
Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
datho7561
approved these changes
Jun 6, 2023
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good! Thanks Muthu!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: msivasubramaniaan msivasub@redhat.com
Fix: #2489