Skip to content

changed height to rem from vh#2934

Merged
datho7561 merged 3 commits intoredhat-developer:mainfrom
msivasubramaniaan:2930-decrease-spacing-in-between-paragraphs-on-welcome-page
Jun 5, 2023
Merged

changed height to rem from vh#2934
datho7561 merged 3 commits intoredhat-developer:mainfrom
msivasubramaniaan:2930-decrease-spacing-in-between-paragraphs-on-welcome-page

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

Signed-off-by: msivasubramaniaan msivasub@redhat.com

Fix: #2930

Post Fix:
image

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (76469c0) 37.32% compared to head (652db67) 37.32%.

❗ Current head 652db67 differs from pull request most recent head 5a1aca6. Consider uploading reports for the commit 5a1aca6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2934   +/-   ##
=======================================
  Coverage   37.32%   37.32%           
=======================================
  Files          54       54           
  Lines        3652     3652           
  Branches      716      716           
=======================================
  Hits         1363     1363           
  Misses       2289     2289           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Comment thread src/webview/welcome/app/welcomePage.tsx Outdated
@datho7561
Copy link
Copy Markdown
Contributor

It looks like the div containing the "OpenShift extension" title on the left is a fixed height (based on vh), so it scrolls past the paragraphs. Is there a way to set it to scale its height to the height of the paragraphs?

LeftTitleBoxIsFixedLength

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator Author

It looks like the div containing the "OpenShift extension" title on the left is a fixed height (based on vh), so it scrolls past the paragraphs. Is there a way to set it to scale its height to the height of the paragraphs?

LeftTitleBoxIsFixedLength

May I know your screen-size and the resolution? I couldn't able to reproduce on my system

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think there is a simpler way to accomplish this, but if you want to release soon, I think this can work for the time being

@datho7561 datho7561 merged commit c0d5474 into redhat-developer:main Jun 5, 2023
@msivasubramaniaan msivasubramaniaan deleted the 2930-decrease-spacing-in-between-paragraphs-on-welcome-page branch June 5, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decrease spacing in between paragraphs on welcome page

2 participants