Move download scripts into ./src#2950
Merged
mohitsuman merged 4 commits intoredhat-developer:mainfrom Jun 7, 2023
Merged
Conversation
- Also list packages that they require as runtime dependencies Fixes redhat-developer#2948 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
requested review from
mohitsuman and
msivasubramaniaan
and removed request for
mohitsuman
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2950 +/- ##
==========================================
+ Coverage 37.36% 38.01% +0.65%
==========================================
Files 57 60 +3
Lines 3715 3809 +94
Branches 729 744 +15
==========================================
+ Hits 1388 1448 +60
- Misses 2327 2361 +34
☔ View full report in Codecov by Sentry. |
Contributor
|
@datho7561 So with this PR, now the vsix files works properly with perfect tools installation ? |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
msivasubramaniaan
previously approved these changes
Jun 7, 2023
Collaborator
|
@datho7561 I have tested your PR and its working fine. Due to release thing I have renamed the folder and pushed the code to your branch |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
msivasubramaniaan
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is because we now use them when the extension is running for installing the tools into dev containers.
Also, list packages that the scripts require as runtime dependencies.
Fixes #2948
Signed-off-by: David Thompson davthomp@redhat.com