Contribute to Kubernetes cloud explorer#2962
Merged
mohitsuman merged 5 commits intoredhat-developer:mainfrom Jun 19, 2023
Merged
Contribute to Kubernetes cloud explorer#2962mohitsuman merged 5 commits intoredhat-developer:mainfrom
mohitsuman merged 5 commits intoredhat-developer:mainfrom
Conversation
JessicaJHee
changed the title
mohitsuman
reviewed
Jun 13, 2023
mohitsuman
reviewed
Jun 13, 2023
JessicaJHee
force-pushed
the
contribute-cloud-explorer
branch
from
7538cf4 to
df71623
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2962 +/- ##
==========================================
- Coverage 37.90% 37.63% -0.28%
==========================================
Files 61 62 +1
Lines 3841 3938 +97
Branches 744 755 +11
==========================================
+ Hits 1456 1482 +26
- Misses 2385 2456 +71
☔ View full report in Codecov by Sentry. |
msivasubramaniaan
previously approved these changes
Jun 19, 2023
Collaborator
msivasubramaniaan
left a comment
msivasubramaniaan
left a comment
There was a problem hiding this comment.
LGTM
Tested in my local and it works as expected
Contributor
|
@JessicaJHee Let's add tooltip for Developer Sandbox and OpenShift Local. |
Updates kubernetes tools cloud explorer with options to signup for Developer Sandbox and Local OpenShift
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
JessicaJHee
force-pushed
the
contribute-cloud-explorer
branch
from
df71623 to
23a2fe7
Compare
Member
Author
Here's what it looks like now: |
mohitsuman
reviewed
Jun 19, 2023
| private buildOpenshiftLocalItem() { | ||
| const openshiftLocalItem = new RedHatCloudItem('Openshift Local'); | ||
| openshiftLocalItem.tooltip = 'Provision OpenShift 4 cluster to your local computer.'; | ||
| openshiftLocalItem.iconPath = new vscode.ThemeIcon('symbol-folder'); |
Contributor
There was a problem hiding this comment.
@JessicaJHee We should use the vm icon here for OpenShift local.
mohitsuman
reviewed
Jun 19, 2023
| const signupStatus = await RedHatTreeDataProvier.getSandboxSignupStatus(); | ||
| const sandboxItem = new RedHatCloudItem('Developer Sandbox'); | ||
| sandboxItem.tooltip = 'Get 30-days free access to a shared OpenShift and Kubernetes cluster.'; | ||
| sandboxItem.iconPath = new vscode.ThemeIcon('vm'); |
Contributor
There was a problem hiding this comment.
@JessicaJHee We should use the openshift logo icon here instead of vm one.
mohitsuman
reviewed
Jun 19, 2023
Contributor
mohitsuman
left a comment
mohitsuman
left a comment
There was a problem hiding this comment.
Change the icons for the cluster providers.
Signed-off-by: Jessica He <jhe@redhat.com>
JessicaJHee
force-pushed
the
contribute-cloud-explorer
branch
from
23a2fe7 to
c9c6da1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2620