Add check for OpenShift cluster when opening developer console#2987
Merged
msivasubramaniaan merged 1 commit intoredhat-developer:mainfrom Jun 28, 2023
Merged
Conversation
Member
Author
|
@mohitsuman I wasn't able to reproduce the error popup since I believe we no longer use |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2987 +/- ##
==========================================
- Coverage 37.59% 35.83% -1.76%
==========================================
Files 62 63 +1
Lines 3937 4152 +215
Branches 755 830 +75
==========================================
+ Hits 1480 1488 +8
- Misses 2457 2664 +207
☔ View full report in Codecov by Sentry. |
Contributor
Yes we should add a check and only show |
msivasubramaniaan
requested changes
Jun 27, 2023
JessicaJHee
force-pushed
the
2628-check-os
branch
from
5d7fc61 to
810d43b
Compare
Signed-off-by: Jessica He <jhe@redhat.com>
JessicaJHee
force-pushed
the
2628-check-os
branch
from
810d43b to
43a31c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2628