Skip to content

"Delete project" warns about deleting project contents#3022

Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561:2023-confirm-delete-project
Jul 14, 2023
Merged

"Delete project" warns about deleting project contents#3022
datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561:2023-confirm-delete-project

Conversation

@datho7561
Copy link
Copy Markdown
Contributor

  • Add some integration tests for the oc commands we call in the file

Closes #2023

Signed-off-by: David Thompson davthomp@redhat.com

- Add some integration tests for the `oc` commands we call in the file

Closes redhat-developer#2023

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the 2023-confirm-delete-project branch from 9c5258e to 05ed7f6 Compare July 13, 2023 19:40
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (4d121d6) 34.74% compared to head (05ed7f6) 34.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3022      +/-   ##
==========================================
+ Coverage   34.74%   34.80%   +0.06%     
==========================================
  Files          64       64              
  Lines        4358     4359       +1     
  Branches      857      858       +1     
==========================================
+ Hits         1514     1517       +3     
+ Misses       2844     2842       -2     
Impacted Files Coverage Δ
src/openshift/project.ts 42.59% <100.00%> (+4.85%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Collaborator

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datho7561 datho7561 merged commit d748f4a into redhat-developer:main Jul 14, 2023
@datho7561 datho7561 deleted the 2023-confirm-delete-project branch July 14, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request if components should be deleted when deleting Application or Project from Application explorer

2 participants